Re: [syzbot] memory leak in smc_create (2)

From: Tony Lu
Date: Thu Mar 31 2022 - 02:42:25 EST


On Mon, Mar 28, 2022 at 01:59:26PM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: ed4643521e6a Merge tag 'arm-dt-5.18' of git://git.kernel.o..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=14d17b99700000
> kernel config: https://syzkaller.appspot.com/x/.config?x=8414405fa34d7154
> dashboard link: https://syzkaller.appspot.com/bug?extid=6e29a053eb165bd50de5
> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16431151700000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15f44cdb700000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+6e29a053eb165bd50de5@xxxxxxxxxxxxxxxxxxxxxxxxx

__smc_release() does not handle it properly when it falls back and
sk_state is SMC_CLOSED but not calls sock_put(). This makes sk leaks.

I will fix it soon.

Tony Lu