Re: [PATCH] dt-bindings: gpio: davinci: list contents of GPIO hogs

[Rob Herring]

On Mon, Mar 28, 2022 at 09:11:53PM +0200, Krzysztof Kozlowski wrote:
> The hogs children should list allowed properties, otherwise any property
> would be accepted.  Simplify also GPIO hog node name pattern.

Only if 'gpio-hog' is missing, because the gpio-hog.yaml schema will 
check every node with that property.

Hogs are allowed on any GPIO controller, but I don't think we to 
duplicate what's here on every schema.

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/gpio/gpio-davinci.yaml        | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> index f32e09ef937c..e5b91c65dcb0 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> @@ -76,12 +76,21 @@ properties:
>      const: 2
>  
>  patternProperties:
> -  "^(.+-hog(-[0-9]+)?)$":
> +  "^.+-hog(-[0-9]+)?$":
>      type: object
> +    properties:
> +      gpio-hog: true
> +      gpios: true
> +      input: true
> +      output-high: true
> +      output-low: true
> +      line-name: true
>  
>      required:
>        - gpio-hog
>  
> +    additionalProperties: false
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.32.0
> 
>