Re: [PATCH 2/2] userfaultfd: selftests: modify selftest to use /dev/userfaultfd

[Andrew Morton]

On Mon, 18 Apr 2022 15:16:02 -0700 Axel Rasmussen <axelrasmussen@xxxxxxxxxx> wrote:

> Thanks for looking Andrew. And, fair criticism.
> 
> In keeping with the status quo, I'm thinking of just adding a new
> command-line argument which toggles between the two modes.

But I think you could tweak the test pretty simply to run itself twice.
Once with the syscall then once with the /dev interface.

I suppose that adding the commandline argument is equivalent, as long
as the upper level script/makefile invokes the test program twice.

> But, if I'm honest, it's starting to feel like the test has way too
> many arguments... I'm tempted to refactor the test to use the
> kselftest framework [1], get rid of all these command line arguments,
> and just always test everything. But, this seems like a big and
> perhaps controversial refactor, so I may take it up after this
> series...

Yes, that's a separable activity.