RE: [PATCH 19/20] tty: n_gsm: fix wrong behavior of gsm_carrier_raised() on debug
From: Starke, Daniel
Date: Tue Apr 19 2022 - 03:59:00 EST
> > From: Daniel Starke <daniel.starke@xxxxxxxxxxx>
> >
> > gsm_carrier_raised() returns always 1 if the kernel module parameter
> > 'debug' has its second least significant bit set. This changes the
> > behavior of the module instead of just adding some debug output.
> > Remove this 'debug' gated early out to avoid debug settings from
> > changing the program flow.
> >
> > Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
> > Cc: stable@xxxxxxxxxxxxxxx
>
> Why is this relevant for stable backporting? It's a debugging feature
> only, and you are changing how it previously worked :(
You are right. This was a mistake on my side. Please ignore this commit
completely.
Best regards,
Daniel Starke