Re: [PATCH] net/smc: sync err info when TCP connection is refused

[Karsten Graul]

On 19/04/2022 12:23, Tony Lu wrote:
> On Sun, Apr 17, 2022 at 08:33:07PM +0800, yacanliu@xxxxxxx wrote:
>> From: liuyacan <liuyacan@xxxxxxxxxxxxxxxx>
>>
>> In the current implementation, when TCP initiates a connection
>> to an unavailable [ip,port], ECONNREFUSED will be stored in the
>> TCP socket, but SMC will not. However, some apps (like curl) use
>> getsockopt(,,SO_ERROR,,) to get the error information, which makes
>> them miss the error message and behave strangely.
>>
>> Signed-off-by: liuyacan <liuyacan@xxxxxxxxxxxxxxxx>
> 
> This fix works for me. I have tested it with curl for unavailable
> address.
> 
> This patch missed net or net-next tag, I think net is preferred.
> 
> Reviewed-by: Tony Lu <tonylu@xxxxxxxxxxxxxxxxx>
> 
> Thank you,
> Tony Lu

Thank you both for the fix and the test!

Acked-by: Karsten Graul <kgraul@xxxxxxxxxxxxx>