Re: [PATCH v2] PM: opp: Fix NULL pointer exception on a v2 table combined with v1 opps

[Krzysztof Kozlowski]

On 11/04/2022 04:49, Viresh Kumar wrote:
> On 04-04-22, 14:37, Krzysztof Kozlowski wrote:
>> dev_pm_opp_add() adds a v1 OPP.
> 
> That's not correct, it adds a simpler version of OPP and doesn't
> support complex types. A opp v2 table with just freq and voltage
> should be supported by dev_pm_opp_add() and we shouldn't disallow it.
> 
> I think all we need here is a couple of checks to make sure the
> earlier OPPs don't have anything which the new OPP can't support. For
> example checking required-opps field, etc.

Would be useful to have list of such new-OPP properties somewhere. I'll
try to rework the patch based on this.


Best regards,
Krzysztof