Re: [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

[Marc Kleine-Budde]

On 06.04.2022 10:20:42, Pavel Pisa wrote:
> Hello Marc and others,
> 
> On Tuesday 22 of March 2022 10:22:12 Marc Kleine-Budde wrote:
> > On 22.03.2022 09:18:32, Pavel Pisa wrote:
> > > > The driver looks much better now. Good work. Please have a look at the
> > > > TX path of the mcp251xfd driver, especially the tx_stop_queue and
> > > > tx_wake_queue in mcp251xfd_start_xmit() and mcp251xfd_handle_tefif(). A
> > > > lockless implementation should work in your hardware, too.
> > >
> > > Is this blocker for now? I would like to start with years tested base.
> >
> > Makes sense.
> 
> I have missed timing for 5.18 but v5.18-rc1 is out so I would be
> happy if we do not miss 5.19 merge window at least with minimal version.

I've taken the patch (almost) as is, I marked both can_bittiming_const
static, as sparse complained about that and I changed the order of two
variable declarations to look nicer :)

Looking forward for more patches!

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature