Re: [PATCH v2] gpiolib: of: fix bounds check for 'gpio-reserved-ranges'
From: Linus Walleij
Date: Tue Apr 19 2022 - 17:53:55 EST
On Fri, Apr 15, 2022 at 9:09 AM Andrei Lalaev <andrei.lalaev@xxxxxxxxx> wrote:
> Gpiolib interprets the elements of "gpio-reserved-ranges" as "start,size"
> because it clears "size" bits starting from the "start" bit in the according
> bitmap. So it has to use "greater" instead of "greater or equal" when performs
> bounds check to make sure that GPIOs are in the available range.
> Previous implementation skipped ranges that include the last GPIO in
> the range.
>
> Fixes: 726cb3ba4969 ("gpiolib: Support 'gpio-reserved-ranges' property")
> Signed-off-by: Andrei Lalaev <andrei.lalaev@xxxxxxxxx>
Nice patch!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Yours,
Linus Walleij