Re: [PATCH] rtc: ftrtc010: Fix error handling in ftrtc010_rtc_probe

[Linus Walleij]

On Sun, Apr 3, 2022 at 7:49 AM Miaoqian Lin <linmq006@xxxxxxxxx> wrote:

> In the error handling path, the clk_prepare_enable() function
> call should be balanced by a corresponding 'clk_disable_unprepare()'
> call , as already done in the remove function.
>
> clk_disable_unprepare calls clk_disable() and clk_unprepare().
> They will use IS_ERR_OR_NULL to check the argument.
>
> Fixes: ac05fba39cc5 ("rtc: gemini: Add optional clock handling")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>

Looks correct!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij