Re: [PATCH v2 0/4] tools/thermal: thermal library and tools

From: srinivas pandruvada
Date: Tue Apr 19 2022 - 23:16:45 EST


Hi Daniel,

On Tue, 2022-04-19 at 22:26 +0200, Daniel Lezcano wrote:
>
> Hi Srinivas,
>
>
> On 18/04/2022 05:36, srinivas pandruvada wrote:
> > Hi Daniel,
> >
> > The attached diff fixes the crash,
> >
> > Also when you run in daemon mode, you need to use some pid lock
> > file.
> > Otherwise it launches multiple daemons.
>
> I've been thinking about it and I don't think it is a problem to have
> multiple instances of the daemon. The netlink allows multicast and
> can
> be run as non-root user.
>
> If the finality of the thermal engine is to manage the system and has
> some code making actions on the system with the root privilege, the
> init
> scripts can take care of the pid lock
>
If there is use case, then this is fine otherwise wasting system
resources.

Thanks,
Srinivas





>
>