Re: [PATCH 2/3] dt-bindings: arm: mediatek: apmixedsys: Convert to DT schema

From: Krzysztof Kozlowski
Date: Wed Apr 20 2022 - 02:50:12 EST


On 19/04/2022 20:09, Yassine Oudjana wrote:

Thank you for your patch. There is something to discuss/improve.

> +
> +title: MediaTek AP Mixedsys Controller
> +
> +maintainers:
> + - Matthias Brugger <matthias.bgg@xxxxxxxxx>
> +
> +description:
> + The Mediatek apmixedsys controller provides PLLs to the system.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:

Same comments as patch 1 - no need for items here, just enum. Please
also put the new binding in clock subsystem.

Best regards,
Krzysztof