Re: [PATCH v2 4/4] KVM: s390: selftests: Use TAP interface in the reset test

[Janosch Frank]

On 4/19/22 20:58, Thomas Huth wrote:
> Let's standardize the s390x KVM selftest output to the TAP output
> generated via the kselftests.h interface.
>
> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
> ---

Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx>

[...]
> -	return 0;
> +
> +	ksft_finished();

main() is still int so it looks really weird, that we remove the return 
here. After reading the ksft_finished() code I know that we never return 
because we do an exit() but I'd like to have a comment, change to void 
or noreturn tag to make this clearer.

I'd guess that's true for all 4 patches.

>   }