Re: [PATCH v3 03/21] x86/virt/tdx: Implement the SEAMCALL base function
From: Kai Huang
Date: Wed Apr 20 2022 - 06:40:09 EST
On Wed, 2022-04-20 at 00:29 -0700, Sathyanarayanan Kuppuswamy wrote:
>
> On 4/19/22 9:16 PM, Kai Huang wrote:
> > On Tue, 2022-04-19 at 07:07 -0700, Sathyanarayanan Kuppuswamy wrote:
> > >
> > > On 4/5/22 9:49 PM, Kai Huang wrote:
> > > > SEAMCALL leaf functions use an ABI different from the x86-64 system-v
> > > > ABI. Instead, they share the same ABI with the TDCALL leaf functions.
> > >
> > > TDCALL is a new term for this patch set. Maybe add some detail about
> > > it in ()?.
> > >
> > > >
> >
> > TDCALL implementation is already in tip/tdx. This series will be rebased to it.
> > I don't think we need to explain more about something that is already in the tip
> > tree?
>
> Since you have already expanded terms like TD,TDX and SEAM in this patch
> set, I thought you wanted to explain TDX terms to make it easy for new
> readers. So to keep it uniform, I have suggested adding some brief
> details about the TDCALL.
>
>
All right. I can add one sentence to explain it.
--
Thanks,
-Kai