Re: [PATCH] mm/uffd: Move USERFAULTFD configs into mm/
From: Axel Rasmussen
Date: Wed Apr 20 2022 - 12:47:11 EST
Reviewed-by: Axel Rasmussen <axelrasmussen@xxxxxxxxxx>
On Wed, Apr 20, 2022 at 8:31 AM Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
>
> On Wed, Apr 20, 2022 at 10:48:23AM -0400, Peter Xu wrote:
> > We used to have USERFAULTFD configs stored in init/. It makes sense as a
> > start because that's the default place for storing syscall related configs.
> >
> > However userfaultfd evolved a bit in the past few years and some more
> > config options were added. They're no longer related to syscalls and start
> > to be not suitable to be kept in the init/ directory anymore, because
> > they're pure mm concepts.
> >
> > But it's not ideal either to keep the userfaultfd configs separate from
> > each other. Hence this patch moves the userfaultfd configs under init/ to
> > be under mm/ so that we'll start to group all userfaultfd configs
> > together.
> >
> > We do have quite a few examples of syscall related configs that are not put
> > under init/Kconfig: FTRACE_SYSCALLS, SWAP, FILE_LOCKING, MEMFD_CREATE..
> > They all reside in the dir where they're more suitable for the concept. So
> > it seems there's no restriction to keep the role of having syscall related
> > CONFIG_* under init/ only.
> >
> > Suggested-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> > Signed-off-by: Peter Xu <peterx@xxxxxxxxxx>
>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>