Re: [PATCH] tcp: md5: incorrect tcp_header_len for incoming connections

[Eric Dumazet]

On Wed, Apr 20, 2022 at 5:32 PM Francesco Ruggeri <fruggeri@xxxxxxxxxx> wrote:
>
> On Wed, Apr 20, 2022 at 5:20 PM Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
> > On Wed, Apr 20, 2022 at 4:57 PM Francesco Ruggeri <fruggeri@xxxxxxxxxx> wrote:
> > This seems like a day-0 bug, right ?
> >
> > Do you agree on adding
> >
> > Fixes: cfb6eeb4c860 ("[TCP]: MD5 Signature Option (RFC2385) support.")
> >
> > Thanks.
> >
> I also think it is a day-0 bug. Should I resubmit with "Fixes:" ?

I think so. It will make things a bit easier for network maintainers,
because I do not think patchwork catches Fixes: tags added during code review.

Also please add the net prefix, as in [PATCH v2 net] title  (look at
the warning at https://patchwork.kernel.org/project/netdevbpf/patch/20220420235659.830155EC021C@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/
)

Thanks.