Re: [PATCH v2 net] tcp: md5: incorrect tcp_header_len for incoming connections

[Eric Dumazet]

On Wed, Apr 20, 2022 at 5:50 PM Francesco Ruggeri <fruggeri@xxxxxxxxxx> wrote:
>
> In tcp_create_openreq_child we adjust tcp_header_len for md5 using the
> remote address in newsk. But that address is still 0 in newsk at this
> point, and it is only set later by the callers (tcp_v[46]_syn_recv_sock).
> Use the address from the request socket instead.
>
>
>
> Fixes: cfb6eeb4c860 ("[TCP]: MD5 Signature Option (RFC2385) support.")
> Signed-off-by: Francesco Ruggeri <fruggeri@xxxxxxxxxx>

Thanks for fixing this Francesco.

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>