Re: [PATCH 1/5] net: mdio: Mask PHY only when its ACPI node is present

From: Kai-Heng Feng
Date: Wed Apr 20 2022 - 22:59:06 EST


On Wed, Apr 20, 2022 at 10:47 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> On Wed, Apr 20, 2022 at 08:40:48PM +0800, Kai-Heng Feng wrote:
> > Not all PHY has an ACPI node, for those nodes auto probing is still
> > needed.
>
> Why do you need this?
>
> Documentation/firmware-guide/acpi/dsd/phy.rst
>
> There is nothing here about there being PHYs which are not listed in
> ACPI. If you have decided to go the ACPI route, you need to list the
> PHYs.

This is for backward-compatibility. MAC can have ACPI node but PHY may
not have one.

On ACPI based platform, stmmac is using mdiobus_register() and its PHY
is using autoprobing, so masking all PHYs from autoprobing will break
those stmmac users.

Kai-Heng

>
> Andrew