Re: [PATCH v2 06/12] md/raid5: Drop the do_prepare flag in raid5_make_request()

From: Christoph Hellwig
Date: Thu Apr 21 2022 - 02:15:06 EST


On Wed, Apr 20, 2022 at 01:54:19PM -0600, Logan Gunthorpe wrote:
> prepare_to_wait() can be reasonably called after schedule instead of
> setting a flag and preparing in the next loop iteration.
>
> This means that prepare_to_wait() will be called before
> read_seqcount_begin(), but there shouldn't be any reason that
> the order matters here. On the first iteration of the loop
> prepare_to_wait() is already called first.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>