Re: [PATCH v8 4/7] dax: introduce DAX_RECOVERY_WRITE dax access mode

From: Christoph Hellwig
Date: Thu Apr 21 2022 - 02:57:51 EST


> + if (bb->count &&
> + badblocks_check(bb, sector, num, &first_bad, &num_bad)) {

Weird alignment here, continuing lines for conditionals are aligned
either after the opening brace:

if (bb->count &&
badblocks_check(bb, sector, num, &first_bad, &num_bad)) {

or with double tabs. I tend to prefer the version I posted above.

The being said, shouldn't this change even be in this patch and not just
added once we add actual recovery support?