Re: [PATCH v9 03/21] cachefiles: unbind cachefiles gracefully in on-demand mode

[David Howells]

Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx> wrote:

> +	struct kref			unbind_pincount;/* refcount to do daemon unbind */

Please use refcount_t or atomic_t, especially as this isn't the refcount for
the structure.

> -	cachefiles_daemon_unbind(cache);
> -
>  	/* clean up the control file interface */
>  	cache->cachefilesd = NULL;
>  	file->private_data = NULL;
>  	cachefiles_open = 0;

Please call cachefiles_daemon_unbind() before the cleanup.

David