Re: [RFC 1/3] mm: change vma_is_anonymous to vma_is_private_anon

From: Matthew Wilcox
Date: Thu Apr 21 2022 - 15:28:47 EST


On Thu, Apr 21, 2022 at 03:05:31PM -0400, Nico Pache wrote:
> The vma_is_anonymous function isn't fully indicative of what it checks.
>
> Without having full knowledge of the mmap process, one may incorrectly
> assume this covers all types of anonymous memory; which is not the case.

Is your complaint that anonymous memory can also be found in file VMAs
that were mapped with MAP_PRIVATE? ie COWed pages?

I don't think renaming this function is appropriate. It's whether
the VMA is anonymous, not whether the VMA can contain anonymous
pages.