Re: [RFC 2/3] futex: exit: Print a warning when futex_cleanup fails

From: Matthew Wilcox
Date: Thu Apr 21 2022 - 15:30:39 EST


On Thu, Apr 21, 2022 at 03:05:32PM -0400, Nico Pache wrote:
> @@ -1007,13 +1013,15 @@ static inline void exit_pi_state_list(struct task_struct *curr) { }
> static void futex_cleanup(struct task_struct *tsk)
> {
> if (unlikely(tsk->robust_list)) {
> - exit_robust_list(tsk);
> + if (!exit_robust_list(tsk))
> + pr_info("futex: exit_robust_list failed");

Doesn't this allow a malicious user process to spam the kernel logs
with messages? There needs to be a ratelimit on this, at least.