Re: [PATCH] USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static
From: patchwork-bot+netdevbpf
Date: Fri Apr 22 2022 - 07:50:18 EST
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@xxxxxxxxxxxxx>:
On Tue, 19 Apr 2022 10:06:25 -0400 you wrote:
> Smatch reports this issue
> sr9800.h:166:53: warning: symbol 'SR9800_BULKIN_SIZE' was not declared. Should it be static?
>
> Global variables should not be defined in header files.
> This only works because sr9800.h in only included by sr9800.c
> Change the storage-class specifier to static.
> And since it does not change add type qualifier const.
>
> [...]
Here is the summary with links:
- USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static
https://git.kernel.org/netdev/net-next/c/0844d36f771d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html