Re: [PATCH v20 2/8] soc: mediatek: add mtk-mutex support for mt8195 vdosys0

[Matthias Brugger]

On 22/04/2022 04:32, Jason-JH Lin wrote:
> Hi CK,
>
> Thanks for the reviews.
>
> On Thu, 2022-04-21 at 14:50 +0800, CK Hu wrote:
> > Hi, Jason:
> >
> > On Tue, 2022-04-19 at 17:41 +0800, jason-jh.lin wrote:
> > > Add mtk-mutex support for mt8195 vdosys0.
> > >
> > > Signed-off-by: jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx>
> > > Acked-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@xxxxxxxxxxxxx>
> > > Tested-by: Fei Shao <fshao@xxxxxxxxxxxx>
> > > ---
> > >   drivers/soc/mediatek/mtk-mutex.c | 87
> > > ++++++++++++++++++++++++++++++--
> > >   1 file changed, 84 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/soc/mediatek/mtk-mutex.c
> > > b/drivers/soc/mediatek/mtk-mutex.c
> > > index aaf8fc1abb43..729ee88035ed 100644
> > > --- a/drivers/soc/mediatek/mtk-mutex.c
> > > +++ b/drivers/soc/mediatek/mtk-mutex.c
> > > @@ -17,6 +17,9 @@
> > >   #define MT8183_MUTEX0_MOD0			0x30
> > >   #define MT8183_MUTEX0_SOF0			0x2c
> > >   
> > > +#define MT8195_DISP_MUTEX0_MOD0			0x30
> > > +#define MT8195_DISP_MUTEX0_SOF			0x2c
> >
> > This is identical to mt8183, so use mt8183 one instead of creating
> > new
> > one.
> >
> > Regards,
> > CK
> I'll fix this in the next version.

Please send this as a follow-up fix on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/log/?h=v5.18-next/soc

Regards,
Matthias

> Regards,
> Jason-JH.Lin.
> > >   
> > > +static const struct mtk_mutex_data mt8195_mutex_driver_data = {
> > > +	.mutex_mod = mt8195_mutex_mod,
> > > +	.mutex_sof = mt8195_mutex_sof,
> > > +	.mutex_mod_reg = MT8195_DISP_MUTEX0_MOD0,
> > > +	.mutex_sof_reg = MT8195_DISP_MUTEX0_SOF,
> > > +};
> > > +
> > >