RE: [PATCH] gpio: xilinx: Trivial patch

[Radhey Shyam Pandey]

> -----Original Message-----
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> Sent: Tuesday, February 22, 2022 6:46 PM
> To: linux-gpio@xxxxxxxxxxxxxxx
> Cc: git <git@xxxxxxxxxx>; Michal Simek <michals@xxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; Shubhrajyoti Datta <shubhraj@xxxxxxxxxx>
> Subject: [PATCH] gpio: xilinx: Trivial patch

Minor nit - Better to say about the change instead of "trivial patch".
gpio: xilinx: add missing blank line after declarations

> 
> Add a missing blank line. No functional changes.
> 
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_set_value32(a, bit, xgpio_readreg(addr));
> 
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_writereg(addr, xgpio_get_value32(a, bit));
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>
Thanks!
> ---
>  drivers/gpio/gpio-xilinx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c index
> b6d3a57e27ed..7f129e7eae78 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_instance
> *chip, int ch)  static void xgpio_read_ch(struct xgpio_instance *chip, int reg,
> int bit, unsigned long *a)  {
>  	void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit /
> 32);
> +
>  	xgpio_set_value32(a, bit, xgpio_readreg(addr));  }
> 
>  static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit,
> unsigned long *a)  {
>  	void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit /
> 32);
> +
>  	xgpio_writereg(addr, xgpio_get_value32(a, bit));  }
> 
> --
> 2.17.1