Re: [PATCH v5 01/11] archh: arm: mach-hpe: Introduce the HPE GXP architecture
From: Arnd Bergmann
Date: Fri Apr 22 2022 - 09:20:40 EST
On Thu, Apr 21, 2022 at 9:21 PM <nick.hawkins@xxxxxxx> wrote:
> +
> +DT_MACHINE_START(GXP_DT, "HPE GXP")
> + .dt_compat = gxp_board_dt_compat,
> + .l2c_aux_val = 0,
> + .l2c_aux_mask = 0,
> +MACHINE_END
Ther l2c initialization looks wrong here, where you are saying here is
that all the bits of the aux register must be set to zero.
I also see that you don't have a device node for the cache controller, so
this is probably not actually used, but in general there should be one with
the correct properties.
Arnd