Re: [PATCH v3 2/2] x86/sev: Get the AP jump table address from secrets page

[Tom Lendacky]

On 4/22/22 08:56, Michael Roth wrote:
> From: Brijesh Singh <brijesh.singh@xxxxxxx>
>
> The GHCB specification section 2.7 states that when SEV-SNP is enabled,
> a hypervisor must provide the AP jump table physical address through

I missed this on the first version. It's not the hypervisor, but the guest 
BIOS that directly provides the AP jump table physical address, in our 
case OVMF sets the address in the SNP secrets page. This allows 
communication between UEFI/BIOS and OS without hypervisor involvement.

> the SNP secrets pages.
>
> Fixes: 0afb6b660a6b ("x86/sev: Use SEV-SNP AP creation to start secondary CPUs")
> Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>
> [ mroth: improve error handling when ioremap()/memremap() return NULL ]
> [ mroth: don't mix function calls with declarations ]
> [ mroth: add missing __init ]
> Signed-off-by: Michael Roth <michael.roth@xxxxxxx>

With the commit message change:

Reviewed-by: Tom Lendacky <thomas.lendacky@xxxxxxx>