Re: [PATCH net 2/3] ip6_gre: Make o_seqno start from 0 in native mode

[William Tu]

On Thu, Apr 21, 2022 at 3:08 PM Peilin Ye <yepeilin.cs@xxxxxxxxx> wrote:
>
> From: Peilin Ye <peilin.ye@xxxxxxxxxxxxx>
>
> For IP6GRE and IP6GRETAP devices, currently o_seqno starts from 1 in
> native mode.  According to RFC 2890 2.2., "The first datagram is sent
> with a sequence number of 0."  Fix it.
>
> It is worth mentioning that o_seqno already starts from 0 in collect_md
> mode, see the "if (tunnel->parms.collect_md)" clause in __gre6_xmit(),
> where tunnel->o_seqno is passed to gre_build_header() before getting
> incremented.
>
> Fixes: c12b395a4664 ("gre: Support GRE over IPv6")
> Signed-off-by: Peilin Ye <peilin.ye@xxxxxxxxxxxxx>

LGTM
Acked-by: William Tu <u9012063@xxxxxxxxx>