Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue

From: Allen Pais
Date: Fri Apr 22 2022 - 12:49:05 EST



>> The tasklet is an old API which will be deprecated, workqueue API
>> cab be used instead of them.
>>
>> This patch replaces the tasklet usage in drivers/dma/* with a
>> simple work.
>
> Thanks for working on this! Can you describe the process for the
> replacement? For example, was it a 1:1 replacement from one set of
> functions to another, or something more nuanced? Did you do this by hand,
> or with the help of something like Coccinelle?

For this series, I did the work manually as certain had the potential to be improved.
Also, there are drivers which use queue_work() instead of schedule_work().

> Including these details will help maintainers with review, and will help
> others do other conversions in the future.
>

I will wait for a couple of more days and send out the rest of the series with
More details.

Thanks.

> Thanks!
>
> -Kees
>
> --
> Kees Cook