Re: [PATCH] clk: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

[Stephen Boyd]

Quoting cgel.zte@xxxxxxxxx (2022-04-18 04:04:55)
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
> 
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> ---
>  drivers/clk/clk.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index ed119182aa1b..544e940bf40b 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -113,12 +113,8 @@ static int clk_pm_runtime_get(struct clk_core *core)
>         if (!core->rpm_enabled)
>                 return 0;
>  
> -       ret = pm_runtime_get_sync(core->dev);
> -       if (ret < 0) {
> -               pm_runtime_put_noidle(core->dev);
> -               return ret;
> -       }
> -       return 0;
> +       ret = pm_runtime_resume_and_get(core->dev);
> +       return ret;

	return pm_runtime_resume_and_get()

? I got it.