Re: iwlwifi: iwl-dbg: Use del_timer_sync() before freeing

[Kalle Valo]

Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

> In Chrome OS, a large number of crashes is observed due to corrupted timer
> lists. Steven Rostedt pointed out that this usually happens when a timer
> is freed while still active, and that the problem is often triggered
> by code calling del_timer() instead of del_timer_sync() just before
> freeing.
> 
> Steven also identified the iwlwifi driver as one of the possible culprits
> since it does exactly that.
> 
> Reported-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Johannes Berg <johannes.berg@xxxxxxxxx>
> Cc: Gregory Greenman <gregory.greenman@xxxxxxxxx>
> Fixes: 60e8abd9d3e91 ("iwlwifi: dbg_ini: add periodic trigger new API support")
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Acked-by: Gregory Greenman <gregory.greenman@xxxxxxxxx>
> Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx> # Linux v5.17.3-rc1 and Debian LLVM-14

Patch applied to wireless.git, thanks.

7635a1ad8d92 iwlwifi: iwl-dbg: Use del_timer_sync() before freeing

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220411154210.1870008-1-linux@xxxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches