Re: [PATCH linux-next] clk: keystone: sci-clk: change `struct sci_clk **clk` to `struct sci_clk *clk`

From: Nishanth Menon
Date: Sat Apr 23 2022 - 10:27:43 EST


On 19:06-20220422, Stephen Boyd wrote:
> Quoting Guo Zhengkui (2022-04-05 22:02:32)
> > `struct sci_clk **clk` is unnecessary. Change it to `struct sci_clk *clk`.
> >
> > Also fix functions relating to it.
> >
> > Signed-off-by: Guo Zhengkui <guozhengkui@xxxxxxxx>
> > ---
>
> Waiting for Nishanth to review.

Sorry, this has to be a NAK from me. Broke all the K3 boards. I have'nt
dug to see why exactly.

https://gist.github.com/nmenon/de29ec88efc9f83acc4a8d2c13580290


Compare
vanilla next-20220422:
https://gist.github.com/nmenon/de29ec88efc9f83acc4a8d2c13580290#file-next-20220422-L631

Vs

next-20220422 + this patch:
https://gist.github.com/nmenon/de29ec88efc9f83acc4a8d2c13580290#file-next-20220422-patch-L631


Just posting am64xx-evm log, all other platforms follow the same
pattern.

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D