Re: [PATCH net] net: ethernet: ave: Remove duplicate suspend/resume calls for phy

[Kunihiko Hayashi]

Hi,

On 2022/10/22 5:55, Heiner Kallweit wrote:
> On 21.10.2022 19:45, Kunihiko Hayashi wrote:
> > Since AVE has its own suspend/resume functions, there is no need to call
> > mdio_bus suspend/resume functions. Set phydev->mac_managed_pm to true
> > to avoid the calls.
> The commit description doesn't make clear (any longer) what the issue
> is that you're fixing. You should mention the WARN_ON() dump here
> like in your first attempt.

Indeed, I forgot to mention the WARN_ON() dump issue.

> > In addition, ave_open() executes __phy_resume() via phy_start() in
> > ave_resume(), so no need to call phy_resume() explicitly. Remove it.
> This sounds like an improvement, being independent of the actual fix.
> The preferred approach would be:
> - submit the fix to net
> - submit the improvement in a separate patch to net-next

Ah, I see.
The one is for fixing WARN_ON() dump, and the other isn't affected
by the behavior, but it should be duplicate removal.

I'll separate it into two patches.

Thank you,

---
Best Regards
Kunihiko Hayashi