Re: [PATCH v13 03/35] KVM: Use gfn instead of hva for mmu_notifier_retry

[Paolo Bonzini]

On 10/27/23 20:21, Sean Christopherson wrote:
> From: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx> Currently in mmu_notifier 
> invalidate path, hva range is recorded and then checked against by 
> mmu_notifier_retry_hva() in the page fault handling path. However, for 
> the to be introduced private memory, a page fault may not have a hva 
> associated, checking gfn(gpa) makes more sense. For existing hva based 
> shared memory, gfn is expected to also work. The only downside is when 
> aliasing multiple gfns to a single hva, the current algorithm of 
> checking multiple ranges could result in a much larger range being 
> rejected. Such aliasing should be uncommon, so the impact is expected 
> small.

Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

Paolo