Re: [PATCH v3 4/4] x86/cpufeatures: Use AWK to generate {REQUIRED|DISABLED}_MASK_BIT_SET

[Xin Li]

On 6/23/2024 1:28 PM, Brian Gerst wrote:
> On Sat, Jun 22, 2024 at 1:14 PM Xin Li (Intel) <xin@xxxxxxxxx> wrote:
> > Generate macros {REQUIRED|DISABLED}_MASK_BIT_SET in the newly added AWK
> > script that generates the required and disabled feature mask header.
> >
> > Suggested-by: Brian Gerst <brgerst@xxxxxxxxx>
> > Signed-off-by: Xin Li (Intel) <xin@xxxxxxxxx>
> > ---

> Checking NCAPINTS isn't necessary anymore.  It was needed when these
> macros had to be manually updated, but now if cpufeatures.h changes
> this header will be regenerated.
>
> >          }
> >
> >          printf "#endif /* _ASM_X86_FEATUREMASKS_H */\n";
> > --
> > 2.45.2
>
> Otherwise, it looks good.

Do you mind to give a review-by?

Thanks!
    Xin