Re: [PATCH] genirq/msi: Add the address and data that show MSI/MSIX

[Hans Zhang]

On 2025/2/28 02:03, Frank Li wrote:
> On Fri, Feb 28, 2025 at 12:49:38AM +0800, Hans Zhang wrote:
> > Thanks Mani for the tip.
> >
> > If I want to implement similar functionality, where should I add it? Since
> > this sysfs node is the only one that displays the MSI/MSIX interrupt number,
> > I don't know where to implement similar debug functionality at this time. Do
> > you have any suggestions? Or it shouldn't have a similar function.
>
> I think it is useful feature to help debug. Generally only one property
> for one sys file.
>
> A possible create 3 files under
>
> /sys/kernel/irq/26/
> 	address_hi, address_lo, msg_data.
>
> cat address_hi, only show 0x00000000. ... ABI doc need update also.
>
> Thomas(tglx) may provide better suggestions.

Thank you very much for Frank's opinion and agreeing with my idea. I 
also think this is a good debug method.

I will reply to Thomas(tglx) later, and then please review whether the 
patch I provided is OK?

Best regards
Hans