Re: [PATCH v4 1/1] Documentation: iio: Add ADC documentation

[Jonathan Cameron]

On Sat, 22 Feb 2025 13:43:31 -0300
Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx> wrote:

> On 02/20, Bagas Sanjaya wrote:
> > On Wed, Feb 19, 2025 at 06:00:56PM -0300, Marcelo Schmitt wrote:  
> > > +For a **single-ended bipolar** channel, the analog voltage input can go from
> > > +-VREF to +VREF (where -VREF is the voltage reference that has the lower
> > > +electrical potential while +VREF is the reference with the higher one). Some ADC
> > > +chips derive the lower reference from +VREF, others get it from a separate  
> >                                                   "... obtain it ..."  
> Ack. Maybe, if there are no additional suggestions to the docs, Jonathan can
> tweak this while applying the patch? Otherwise I'll change accordingly on v5.
That one is marginal.  Formal vs less formal language with slightly different
emphasis.  I think either works here.
> 
> > > +input. Often, +VREF and -VREF are symmetric but they don't need to be so. When
> > > +-VREF is lower than system ground, these inputs are also called single-ended
> > > +true bipolar. Also, while there is a relevant difference between bipolar and
> > > +true bipolar from the electrical perspective, IIO makes no explicit distinction
> > > +between them.
> > > +
> > > <snipped>...
> > > +In the ADC driver, ``differential = 1`` is set into ``struct iio_chan_spec`` for
> > > +the channel. Even though, there are three general input types, ``differential``
> > > +is only used to distinguish between differential and not differential (either  
> >                                                    "... non-differential ..."  
> Ack. Same as the other suggestion.

I agree with this change - tweaked and patch applied.

Thanks,

Jonathan

> 
> > > +single-ended or pseudo-differential) input types. See
> > > +``include/linux/iio/iio.h`` for more information.  
> > 
> > Thanks.
> > 
> > -- 
> > An old man doll... just what I always wanted! - Clara  
> 
> 
> Thanks,
> 
> Marcelo