Re: [PATCH 5/7] MIPS: dec: Remove dec_irq_dispatch()

From: Thomas Bogendoerfer
Date: Mon Mar 03 2025 - 04:42:56 EST


On Mon, Mar 03, 2025 at 12:23:13PM +0800, WangYuli wrote:
> Hi Maciej,
>
> On 2025/3/1 00:01, Maciej W. Rozycki wrote:
> > Up to commit 8f99a16265353 ("MIPS: Tracing: Add IRQENTRY_EXIT section for
> > MIPS") `do_IRQ' used to be a macro, that's why. At the time `do_IRQ' was
> > converted to a macro `dec_irq_dispatch' was created and previously this
> > place used to call `do_IRQ' too.
> >
> > It's always good finding out why things are as they are so as to make
> > sure you haven't been missing something. This cleanup should have been
> > made along with commit 8f99a16265353, so it's pretty old a technical debt
> > being sorted here.
> >
> > Please add these findings to your commit description in v2.
>
> Alright, thank you for the correction.
>
> I do see that this commit has already been applied to mips-next.
>
>  If it's alright with you and Thomas, I'm happy to send a patch v2 to
> include these details soon.

I'll drop the applied patch and take your v2.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]