RE: [PATCH v15 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver

[Havalige, Thippeswamy]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Wilczyński <kw@xxxxxxxxx>
> Sent: Monday, March 3, 2025 3:28 PM
> To: Havalige, Thippeswamy <thippeswamy.havalige@xxxxxxx>
> Cc: bhelgaas@xxxxxxxxxx; lpieralisi@xxxxxxxxxx;
> manivannan.sadhasivam@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx>;
> Gogada, Bharat Kumar <bharat.kumar.gogada@xxxxxxx>;
> jingoohan1@xxxxxxxxx
> Subject: Re: [PATCH v15 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver
>
> Hello,
>
> [...]
> > +           err = devm_request_irq(dev, irq,
> amd_mdb_pcie_intr_handler,
> > +                                  IRQF_NO_THREAD, intr_cause[i].sym,
> pcie);
> > +           if (err) {
> > +                   dev_err(dev, "Failed to request IRQ %d\n", irq);
> > +                   return err;
> > +           }
> > +   }
>
> Out of curiosity: would exposing error values be of any benefit to the users of
> the driver?  So, perhaps:
>
>   if (err) {
>       dev_err(dev, "Failed to request IRQ %d, err=%d\n", irq, err);
>       return err;
>   }
Thanks for reviewing. Yes, this would help to understand the error details here.
>
> Thoughts?
>
>       Krzysztof