Re: [PATCH v15 04/10] Coresight: Introduce a new struct coresight_path

[Jie Gan]

On 3/5/2025 12:10 AM, Suzuki K Poulose wrote:
> On 03/03/2025 03:29, Jie Gan wrote:
> > Introduce a new strcuture, 'struct coresight_path', to store the data 
> > that
> > utilized by the devices in the path. The coresight_path will be built/ 
> > released
> > by coresight_build_path/coresight_release_path functions.
> >
> > Signed-off-by: Jie Gan <quic_jiegan@xxxxxxxxxxx>
> > ---
> >   drivers/hwtracing/coresight/coresight-core.c  | 16 +++++-----
> >   .../hwtracing/coresight/coresight-etm-perf.c  | 30 ++++++++++---------
> >   .../hwtracing/coresight/coresight-etm-perf.h  |  2 +-
> >   drivers/hwtracing/coresight/coresight-priv.h  |  6 ++--
> >   drivers/hwtracing/coresight/coresight-sysfs.c | 12 ++++----
> >   include/linux/coresight.h                     | 10 +++++++
> >   6 files changed, 44 insertions(+), 32 deletions(-)
>
> ...
>
> > diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> > index ce9a5e71b261..67cf8bdbe5c0 100644
> > --- a/include/linux/coresight.h
> > +++ b/include/linux/coresight.h
> > @@ -329,6 +329,16 @@ static struct coresight_dev_list (var) = 
> > {                \
> >   #define to_coresight_device(d) container_of(d, struct 
> > coresight_device, dev)
> > +/**
> > + * struct coresight_path - data needed by enable/disable path
> > + * @path:              path from source to sink.
>
> This doesn't match the actual variable below.

Hi Suzuki,

Very sorry for the mistake. I should spot it in advance. I will take 
care and enhance the self-checking process in the future.

Jie

> > + * @trace_id:          trace_id of the whole path.
> > + */
> > +struct coresight_path {
> > +    struct list_head    path_list;
> > +    u8            trace_id;
> > +};
> > +
> >   enum cs_mode {
> >       CS_MODE_DISABLED,
> >       CS_MODE_SYSFS,
>
> Suzuki