Re: [PATCH 08/14] scsi: scsi_error: Add a general LUN based error handler

[Markus Elfring]

…
> +++ b/drivers/scsi/scsi_error.c
> @@ -2804,3 +2804,182 @@ bool scsi_get_sense_info_fld(const u8 *sense_buffer, int sb_len,
…
> +static void sdev_eh_add_cmnd(struct scsi_cmnd *scmd)
> +{
…
> +	spin_lock_irqsave(&luneh->eh_lock, flags);
> +	list_add_tail(&scmd->eh_entry, &luneh->eh_cmd_q);
> +	luneh->eh_num++;
> +	spin_unlock_irqrestore(&luneh->eh_lock, flags);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&luneh->eh_lock);”?
https://elixir.bootlin.com/linux/v6.17-rc1/source/include/linux/spinlock.h#L585-L588

Regards,
Markus