Re: [PATCH] x86: XOP prefix instructions decoder support

From: Alan J. Wylie
Date: Sun Aug 17 2025 - 06:48:33 EST


On Sun, 17 Aug 2025 09:32:40 +0900
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> Hi Alan,
>
> Can you test this with our cros-compile build?
>
> Thank you,

Applies cleanly to both 6.16.0 and 6.16.1, builds natively on both on
my FX-8350 box and boots successfully on both.

Tested-by: Alan J. Wylie <alan@xxxxxxxxxxx>

Thanks

Alan.

>
> On Wed, 30 Jul 2025 16:46:52 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
>
> > From: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> >
> > Support decoding AMD's XOP prefix encoded instructions.
> >
> > These instructions are introduced for Bulldozer micro architecture,
> > and not supported on Intel's processors. But when compiling kernel
> > with CONFIG_X86_NATIVE_CPU on some AMD processor (e.g. -march=bdver2),
> > these instructions can be used.
> >
> > Reported-by: Alan J. Wylie <alan@xxxxxxxxxxx>
> > Closes: https://lore.kernel.org/all/871pq06728.fsf@xxxxxxxxxxx/
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > ---
> > arch/x86/include/asm/inat.h | 15 +++
> > arch/x86/include/asm/insn.h | 51 +++++++++
> > arch/x86/lib/inat.c | 13 ++
> > arch/x86/lib/insn.c | 35 +++++-
> > arch/x86/lib/x86-opcode-map.txt | 111 ++++++++++++++++++++
> > arch/x86/tools/gen-insn-attr-x86.awk | 44 ++++++++
> > tools/arch/x86/include/asm/inat.h | 15 +++
> > tools/arch/x86/include/asm/insn.h | 51 +++++++++
> > tools/arch/x86/lib/inat.c | 13 ++
> > tools/arch/x86/lib/insn.c | 35 +++++-
> > tools/arch/x86/lib/x86-opcode-map.txt | 111 ++++++++++++++++++++
> > tools/arch/x86/tools/gen-insn-attr-x86.awk | 44 ++++++++
> > .../util/intel-pt-decoder/intel-pt-insn-decoder.c | 2
> > 13 files changed, 513 insertions(+), 27 deletions(-)



--
Alan J. Wylie https://www.wylie.me.uk/ mailto:<alan@xxxxxxxxxxx>

Dance like no-one's watching. / Encrypt like everyone is.
Security is inversely proportional to convenience