Re: [PATCH RFC net-next 06/23] net: dsa: lantiq_gswip: load model-specific microcode

[Andrew Lunn]

>  
> +struct gswip_pce_microcode {
> +	u16 val_3;
> +	u16 val_2;
> +	u16 val_1;
> +	u16 val_0;
> +};
> +

I would leave this where it is, and just have

struct gswip_pce_microcode;

Since only a pointer is needed, the compiler does not need the full
type info, at this point.

The structure itself is rather opaque, and only makes some sort of
sense when next to the MAC_ENTRY macro.

    Andrew

---
pw-bot: cr