Re: [PATCH RFC net-next 09/23] net: dsa: lantiq_gswip: add support for SWAPI version 2.3

[Andrew Lunn]

On Sat, Aug 16, 2025 at 08:52:42PM +0100, Daniel Golle wrote:
> Add definition for switch API version 2.3 and a macro to make comparing
> the version more conveniant.
> 
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
> ---
>  drivers/net/dsa/lantiq_gswip.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.h b/drivers/net/dsa/lantiq_gswip.h
> index 433b65b047dd..fd0c01edb914 100644
> --- a/drivers/net/dsa/lantiq_gswip.h
> +++ b/drivers/net/dsa/lantiq_gswip.h
> @@ -7,6 +7,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/regmap.h>
>  #include <linux/reset.h>
> +#include <linux/swab.h>
>  #include <net/dsa.h>
>  
>  /* GSWIP MDIO Registers */
> @@ -93,6 +94,8 @@
>  #define   GSWIP_VERSION_2_1		0x021
>  #define   GSWIP_VERSION_2_2		0x122
>  #define   GSWIP_VERSION_2_2_ETC		0x022
> +#define   GSWIP_VERSION_2_3		0x023
> +#define GSWIP_VERSION_GE(priv, ver)	(swab16(priv->version) >= swab16(ver))

Don't this depend on the endiannes of the CPU?

It seems like it would be better to make your new version member cpu
endian, and when writing to it, do le16_to_cpu().

Also, if i remember correctly, you made version a u32. Should it
really be a u16?

	Andrew