Re: [PATCH v2 12/24] media: iris: Initialize and deinitialize encoder instance structure

[Vikash Garodia]

On 8/18/2025 8:51 AM, Dikshita Agarwal wrote:
>>> diff --git a/drivers/media/platform/qcom/iris/iris_venc.c b/drivers/media/platform/qcom/iris/iris_venc.c
>>> new file mode 100644
>>> index 0000000000000000000000000000000000000000..e418d347ac111c1bc48304adafa259d697e49fed
>>> --- /dev/null
>>> +++ b/drivers/media/platform/qcom/iris/iris_venc.c
>>> @@ -0,0 +1,65 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * Copyright (c) 2022-2025 Qualcomm Innovation Center, Inc. All rights reserved.
>>> + */
>>> +
>>> +#include "iris_buffer.h"
>>> +#include "iris_instance.h"
>>> +#include "iris_venc.h"
>>> +#include "iris_vpu_buffer.h"
>>> +
>>> +int iris_venc_inst_init(struct iris_inst *inst)
>>> +{
>>> +	struct v4l2_format *f;
>>> +
>>> +	inst->fmt_src = kzalloc(sizeof(*inst->fmt_src), GFP_KERNEL);
>>> +	inst->fmt_dst  = kzalloc(sizeof(*inst->fmt_dst), GFP_KERNEL);
>>> +	if (!inst->fmt_src || !inst->fmt_dst)
>>> +		return -ENOMEM;
>> What if inst->fmt_src succeeds while inst->fmt_dst fails, does it frees up
>> inst->fmt_src ?
>>
> would you prefer below?
> 
> if (!inst->fmt_src || !inst->fmt_dst) {
>     kfree(inst->fmt_src);
>     kfree(inst->fmt_dst);
>     return -ENOMEM;
> }
> 

Looks ok..

with that addressed,
Reviewed-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx>

> Thanks,
> Dikshita