Re: [PATCHv2 ath-next] wifi: ath10k: add nvmem support for mac address

From: Miquel Raynal
Date: Mon Aug 18 2025 - 04:00:27 EST


Hi Rosen,

On 11/08/2025 at 13:34:51 -07, Rosen Penev <rosenp@xxxxxxxxx> wrote:

> device_get_mac_address is a generic way to get the MAC address which
> lacks NVMEM support, which tends to be used on embedded platforms.
>
> In case device_get_mac_address fails, try of_get_mac_address_nvmem and
> handle EPROBE_DEFER to wait for the nvmem driver to initialize.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
> v2: keep device_get_mac_address and use of_get_mac_address_nvmem
> added Miquel to CC. Maybe he has insight.

LGTM. I guess it is not possible to make this fallback "the default" in
device_get_mac_address()? In this case doing it in your driver seems
fine if it's used on embedded systems with NVMEM cells described to
store MAC addresses.

Cheers,
Miquèl