Re: [PATCH 2/3] dt-bindings: net: Add support for J-Core EMAC
From: Krzysztof Kozlowski
Date: Mon Aug 18 2025 - 05:58:53 EST
On 18/08/2025 10:21, D. Jeff Dionne wrote:
> On Aug 18, 2025, at 17:07, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
>> git grep jcore,emac
>>
>> Gives me zero?
>
> Um, right. It’s not upstream yet. Thanks for your work to get that done, Artur.
>
>>> If an incompatible version comes up, it should use a different
>>> (versioned?) compatible value.
>>
>> Versions are allowed if they follow some documented and known vendor SoC versioning scheme. Is this the case here?
>>
>> This is some sort of SoC, right? So it should have actual SoC name?
>
> No. It’s a generic IP core for multiple SoCs, which do have names.
Then you need other SoCs compatibles, because we do not allow generic
items. See writing bindings.
>
> This is the correct naming scheme. All compatible devices and SoCs match properly.
No, it is not a correct naming scheme. Please read writing bindings.
Best regards,
Krzysztof