Re: [PATCH 1/4] mm/memory_hotplug: Update comment for hotplug memory callback priorities

[Dave Jiang]

On 8/16/25 12:29 AM, David Hildenbrand wrote:
> On 14.08.25 19:16, Dave Jiang wrote:
>> Add clarification to comment for memory hotplug callback ordering as the
>> current comment does not provide clear language on which callback happens
>> first.
>>
>> Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
>> ---
>>   include/linux/memory.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/memory.h b/include/linux/memory.h
>> index 40eb70ccb09d..02314723e5bd 100644
>> --- a/include/linux/memory.h
>> +++ b/include/linux/memory.h
>> @@ -116,7 +116,7 @@ struct mem_section;
>>     /*
>>    * Priorities for the hotplug memory callback routines (stored in decreasing
>> - * order in the callback chain)
>> + * order in the callback chain). The callback ordering happens from high to low.
>>    */
>>   #define DEFAULT_CALLBACK_PRI    0
>>   #define SLAB_CALLBACK_PRI    1
> 
> "stored in decreasing order in the callback chain"
> 
> is pretty clear? It's a chain after all that gets called.

I can drop the patch. For some reason when I read it I'm thinking the opposite, and when Marc was also confused I started questioning things.

>