Re: [PATCH v3 1/2] dt-bindings: Pinefeat cef168 lens control board

[Conor Dooley]

On Sun, Aug 17, 2025 at 02:05:48PM +0100, Aliaksandr Smirnou wrote:
> Add the Device Tree schema and examples for the Pinefeat cef168 lens
> control board. This board interfaces Canon EF & EF-S lenses with
> non-Canon camera bodies, enabling electronic control of focus and
> aperture via V4L2.
> 

> Power supply is derived from fixed supplies via connector or GPIO
> header. Therefore, the driver does not manage any regulator, so
> representing any supply in the binding is redundant.

Wut? This doesn't make sense, you have supplies so they should be
documented. The fact that they're shared with a bunch of other things on
the SBC you're aiming the product at doesn't matter. What if someone
doesn't use this sensor with an RPi and there is a dedicated regulator?

> Signed-off-by: Aliaksandr Smirnou <support@xxxxxxxxxxxxxx>

Is that actually your email address?

> ---
>  .../bindings/media/i2c/pinefeat,cef168.yaml   | 48 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  MAINTAINERS                                   |  6 +++
>  3 files changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml b/Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
> new file mode 100644
> index 000000000000..80cdff40d175
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2025 Pinefeat LLP
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/pinefeat,cef168.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Pinefeat cef168 lens driver
> +
> +maintainers:
> +  - Aliaksandr Smirnou <support@xxxxxxxxxxxxxx>
> +
> +description: |
> +  Pinefeat produces an adapter designed to interface between
> +  Canon EF & EF-S lenses and non-Canon camera bodies, incorporating
> +  features for electronic focus and aperture adjustment. The cef168
> +  circuit board, included with the adapter, provides a software
> +  programming interface that allows control of lens focus and
> +  aperture positions.

> This driver enables controlling the lens
> +  focus and aperture via the V4L2 (Video4Linux2) API.

Don't mention drivers in bindings, how linux handles things is not
relevant to a hardware description.

Attachment: signature.asc
Description: PGP signature