Re: [PATCH 2/2] arm64: dts: rockchip: Fix Bluetooth interrupts flag on Neardi LBA3368

[Alex Bee]

Am 18.08.25 um 11:04 schrieb Krzysztof Kozlowski:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.
>
> Correct the interrupt flags, assuming the author of the code wanted same
> logical behavior behind the name "ACTIVE_xxx", this is:
>    ACTIVE_HIGH  => IRQ_TYPE_LEVEL_HIGH
>
> Fixes: 7b4a8097e58b ("arm64: dts: rockchip: Add Neardi LBA3368 board")
> Cc: <stable+noautosel@xxxxxxxxxx> # Needs testing, because actual level is just a guess
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> Please kindly test... Not cc-ing stable on purpose, because this might
> have impact, so needs actual testing.

Tested-By: Alex Bee <knaerzche@xxxxxxxxx>

Thanks,

Alex

> ---
>   arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts b/arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
> index b99bb0a5f900..b9801a691b48 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
> @@ -609,7 +609,7 @@ &uart0 {
>   
>   	bluetooth {
>   		compatible = "brcm,bcm4345c5";
> -		interrupts-extended = <&gpio3 RK_PA7 GPIO_ACTIVE_HIGH>;
> +		interrupts-extended = <&gpio3 RK_PA7 IRQ_TYPE_LEVEL_HIGH>;
>   		interrupt-names = "host-wakeup";
>   		clocks = <&rk808 RK808_CLKOUT1>;
>   		clock-names = "lpo";